Skip to content

fix: proposaltablereviewer call and instrument filters#1278

Open
TCMeldrum wants to merge 5 commits intodevelopfrom
1498-fix-fap-reviewers-filters
Open

fix: proposaltablereviewer call and instrument filters#1278
TCMeldrum wants to merge 5 commits intodevelopfrom
1498-fix-fap-reviewers-filters

Conversation

@TCMeldrum
Copy link
Contributor

@TCMeldrum TCMeldrum commented Nov 27, 2025

Closes UserOfficeProject/issue-tracker#1498

Description

This PR enhances the functionality of proposal review by ensuring that reviewers only see calls and instruments that are relevant to their assigned reviews.

I have added new endpoint for these as I could not find a easy way of intergrating it into the current methods.

Motivation and Context

This change is required to streamline the review process and make it more efficient. It solves the problem of reviewers having to sift through irrelevant calls and instruments not assigned to their FAP.

Changes

  • Added methods to retrieve calls and instruments based on FAP IDs in the CallDataSource and InstrumentDataSource interfaces.
  • Implemented these methods in the corresponding data sources.
  • Updated queries in CallQueries and InstrumentQueries to utilize these new methods.
  • Updated resolvers to use the updated queries.
  • Updated frontend to use the new queries and display relevant data to reviewers.

Please note that these changes have been tested and verified to work as expected.

How Has This Been Tested?

Fixes Jira Issue

https://jira.esss.lu.se/browse/

Depends On

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@TCMeldrum TCMeldrum changed the title fix: ProposalTableReviewer call and instrument filters fix: proposaltablereviewer call and instrument filters Nov 27, 2025
@TCMeldrum TCMeldrum marked this pull request as ready for review November 27, 2025 14:10
@TCMeldrum TCMeldrum requested a review from a team as a code owner November 27, 2025 14:10
@TCMeldrum TCMeldrum requested review from bashanlam and removed request for a team November 27, 2025 14:10
@Scott-James-Hurley
Copy link
Contributor

I gave this a whirl but it doesn't seem like all the instruments in the table appear on the filter. I added myself as a reviewer to FAP 11 and then assigned myself some proposals. It looks like on dev FAP 11 only has Ines assigned to it. I guess this is just an issue with the data on dev. Alternatively, you could get the instruments the user can filter from the proposals fetched for the table?
image

@TCMeldrum
Copy link
Contributor Author

@Scott-James-Hurley Thanks for catching that, I have refacoted the db query to get instruments of any proposal that have been assigned to that fap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ProposalTableReviewer Call and Instrument filters show too many options

3 participants