fix: user office experiment safety document disables#1228
fix: user office experiment safety document disables#1228yoganandaness wants to merge 28 commits intodevelopfrom
Conversation
…account management options
…ub.com:UserOfficeProject/user-office-core into SWAP-4997-move-user-info-under-profile-submenu
yoganandaness
requested review from
bashanlam,
janosbabik and
simonfernandes
and removed request for
a team
|
Screen.Recording.2025-10-16.at.17.50.46.mov |
yoganandaness
changed the title
simonfernandes
left a comment
simonfernandes
left a comment
There was a problem hiding this comment.
It looks good. I assumed this is branched from #1209 and so I skipped over reviewing those profile button changes
Oh, thanks a lot for noticing @deepaksftc . I will see how i can pop those changes from this PR |
|
Hi @yoganandaness ! |
…ore into SWAP-4928-user-office-experiment-safety-document-disables
|
|
2 similar comments
|
|
|
|
|
|
1 similar comment
|
|
|
|
|
|
…es' of github.com:UserOfficeProject/user-office-core into SWAP-4928-user-office-experiment-safety-document-disables
|
|
1 similar comment
|
|
4 participants
Description
Fixed refreshing of Exp safety download button visibility by doing request polling of 3 times with delay of 2 seconds each, thereby avoid hard page refresh. Attached Video and Screenshot.
Motivation and Context
When an experiment safety review is approved, the download pdf button should be enabled. Since the status is computed through workflow, it takes some time. Currently, the browser needs to be refreshed to get the visibility of the button. However since this is an inconvenience, request polling has been implemented that fetches the new status and based on the new status, the button visibility is decided
How Has This Been Tested
Manually and attached e2e
Fixes
Avoiding Browser reload
Changes
In the Experiment Safety review summary page, the download button is placed. Instead of window reload, request polling using timeout has been implemented
In addition to the above, the menu has been slightly adjusted, where the experiment safety workflow has been moved next to the Proposal workflow
Depends on
Tests included/Docs Updated?