feat: non numeric grades for faps#1180
Merged
Conversation
TCMeldrum
requested review from
mehta-pooja123
and removed request for
a team
TCMeldrum
changed the title
2 tasks
Scott-James-Hurley
approved these changes
Sep 12, 2025
...ents/questionary/questionaryComponents/FapReviewBasis/QuestionaryComponentFapReviewBasis.tsx
Outdated
Show resolved
Hide resolved
yoganandaness
approved these changes
Oct 15, 2025
yoganandaness
approved these changes
Oct 15, 2025
TCMeldrum
commented
Oct 17, 2025
| ( | ||
| 'dynamic_multiple_choice_question', | ||
| proposal_template_id_var, proposal_topic_id_var, 6, '{"variant":"dropdown", "url":"", "jsonPath":"","isMultipleSelect":true, "apiCallRequestHeaders":[],"readPermissions":[]}' | ||
| proposal_template_id_var, proposal_topic_id_var, 10, '{"variant":"dropdown", "url":"", "jsonPath":"","isMultipleSelect":true, "apiCallRequestHeaders":[],"readPermissions":[]}' |
Contributor
Author
There was a problem hiding this comment.
There were 4 questions with sortOrder 6 meaning the templete export tests was failing as these 6 questiond could appear in the topic array in any order. IDK what about this PR made this unstable but hopefully this should make it more stable going forward
TCMeldrum
commented
Oct 17, 2025
| "dependencies": [], | ||
| "dependenciesOperator": "AND" | ||
| }, | ||
| { |
Contributor
Author
There was a problem hiding this comment.
Regenerated export with fixed sort orders
…OfficeProject/user-office-core into non-numeric-grades-for-faps
…OfficeProject/user-office-core into non-numeric-grades-for-faps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes UserOfficeProject/issue-tracker#1399
Needs UserOfficeProject/user-office-lib#217
Description
Non-numeric grades have been introduced for faps. Added options the the FAP basis question to allow the user office to chose things such as max and min grade, decimal point and what other non number options they would like to set.
Motivation and Context
The change was required to allow for more flexibility and specificity in grading. It addresses the limitation of numeric grading, thereby improving the accuracy of evaluations.
Changes
gradein thefap_reviewstable was altered to typevarchar(30).gradeattribute in theReviewmodel was changed fromnumbertostring.GRADE_PRECISIONwas removed from various files as it is no longer applicable.New options on the FAP proposals basis:
What the user will see:
Recording.2025-10-03.113543.mp4
These changes ensure that the grading system is now capable of handling non-numeric grades and eliminates the need for grade precision settings.
How Has This Been Tested?
Fixes Jira Issue
https://jira.esss.lu.se/browse/
Depends On
Tests included/Docs Updated?