Skip to content

SshHelper does not catch IllegalArgumentException #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emopers wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SshHelper does not catch IllegalArgumentException #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/com/urbancode/terraform/tasks/aws/helpers/SshHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,9 @@ static public InputStreamReader reader(InputStream in) {
//----------------------------------------------------------------------------------------------
static public boolean isPortActive(String host, int port) {
Socket s = null;
if (port < 0 || port > 65535) {
throw new IllegalArgumentException("Port value passed is outside the specified range of valid port values");
}
try {
s = new Socket();
s.setReuseAddress(true);
Expand Down
17 changes: 17 additions & 0 deletions src/test/java/org/urbancode/terraform/tasks/helpers/SshHelperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package org.urbancode.terraform.tasks.helpers;

import java.net.URL;

import org.junit.Assert;
import org.junit.Test;

import com.urbancode.terraform.tasks.aws.helpers.SshHelper;

public class SshHelperTest {

@Test(expected=IllegalArgumentException.class)
public void isPortActiveTest() {
SshHelper.isPortActive("127.0.0.1", 65536);
}

}