239 global footer cta section#256
Open
maryzenn wants to merge 9 commits into
Open
Conversation
I made the text size responsive to the screen size. I just need to add the updated button and maybe do some finishing touches to make it 100% consistent with the design. I also removed the CTA from the pages it was on and put it in the footer. Lmk if you want me to undo that.
Merge main into 239-global-footer-cta-section to get new button.
9 tasks
evanautianle
requested changes
May 10, 2026
Collaborator
evanautianle
left a comment
evanautianle
left a comment
There was a problem hiding this comment.
Hiya, looks great. However:
- Pls use import MemberSignupButton from "./MemberSignupButton"; instead of importing it as Button, cus we have another component that's just called Button so it may be confusing.
- Make sure the capitalisation of the words "Invest, Connect and Work with us" matches with the figma design.
- The figma design for desktop is 1440 wide, so set that as your responsiveness window when testing as shown in fig 1 and you'll see the sizing/ layout is slightly off compared to the figma design in fig 2.
fig 1
fig 2
thankssssss :)))
Contributor
Author
|
hello!! thx for the feedback. I made a few edits to make it more consistent with the design. Ill double check again later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made new CTA section with new button. Also moved it inside the footer.