245 home build restyle hero section#252
Open
nathandalpatan wants to merge 7 commits into
Open
Conversation
9 tasks
andrecamerino
requested changes
May 7, 2026
Collaborator
andrecamerino
left a comment
There was a problem hiding this comment.
Looking good! I've sent you some changes to your discord, here's a quick summary:
- The size of the button should be all good for now, we can change that later
- I think the photo background has some sort of greyed filter to kind of wash it out Check with kade first though
- Are you able to add the white line at the bottom?
- Are you all good to make that new collection?
- I'll have a look at any carousel libraries
andrecamerino
requested changes
May 10, 2026
Collaborator
andrecamerino
left a comment
There was a problem hiding this comment.
Hi @nathandalpatan, almost there!
Logic looks great - just a couple more changes.
Ensure fully responsive
- Can we make sure that the size of the Hero content is responsive - especially with even larger screen sizes?
- The content should be always centered (the group of components - not the text itself), and perhaps the white line at the botto should stretch as well? Ask Kade on #design.
Mobile CTA Button
- On smaller screen sizes, the button should not have an arrow (see Figma design for more details on the button)
- This is because mobile does not use hover states
Just make these 2 changes and should be good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i hard coded the images lmk if u want me to change it to payload data instead