feature/exec grid#69
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new “Meet the SSA Team” section to the About page by introducing reusable About-specific components for rendering executive member cards in a responsive grid, backed by a static data module.
Changes:
- Updated the About page to render a new
ExecGridsection instead of placeholder content. - Added
ExecGridto lay out exec members responsively and render anExecCardper member. - Added
execData.tsto define theExecMembertype and a hardcoded list of members/photos.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| web/src/app/about/page.tsx | Wires the new exec grid section into the About page. |
| web/src/app/about/_components/ExecGrid.tsx | Introduces the responsive grid layout for exec cards. |
| web/src/app/about/_components/ExecCard.tsx | Adds the interactive, image-based exec card (hover/tap overlay). |
| web/src/app/about/_components/execData.ts | Provides the exec member data model and hardcoded member list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…refactor touch event handlers in AboutPage
| year: string | ||
| } | ||
|
|
||
| export const execMembers: ExecMember[] = [ |
There was a problem hiding this comment.
Can u change all 2024 -> 2026
| /> | ||
| <div | ||
| aria-hidden="true" | ||
| className={`absolute inset-0 bg-black/60 flex flex-col justify-end pb-6 pl-5 pr-3 pt-3 sm:pb-8 sm:pl-6 transition-opacity duration-300 ${ |
There was a problem hiding this comment.
Could you please up the duration to 500 instead of 300 so its a bit more gradual
…ecData years for team members Co-authored-by: Copilot <copilot@github.com>
… removing year property Co-authored-by: Copilot <copilot@github.com>
…y; update ExecGrid key prop to use exec.id
| <div | ||
| aria-hidden="true" | ||
| className={`absolute inset-0 bg-black/60 flex flex-col justify-end pb-6 pl-5 pr-3 pt-3 sm:pb-8 sm:pl-6 transition-opacity duration-500 ${ | ||
| isActive ? 'opacity-100' : 'opacity-0 group-hover:opacity-100' |
oorjagandhi
left a comment
There was a problem hiding this comment.
Looks good ! Nice work :D
joengy
left a comment
There was a problem hiding this comment.
Grid looks great Richman, and the code is clean. Good job !!!
This pull request introduces a new "Meet the SSA Team" section to the About page, displaying the executive members in a responsive grid layout. It adds the necessary components and data structure to render executive cards with names, roles, and placeholder photos, and updates the About page to include this new section.
New "Meet the SSA Team" section:
ExecCardcomponent to display individual executive member information with interactive hover/tap overlay effects, including accessibility features for keyboard navigation.ExecGridcomponent to render a responsive grid of all executive members using theExecCardcomponent.execData.tsmodule defining theExecMembertype and a hardcoded list of executive members with placeholder photos (to be replaced by real data in the future).Integration into About page:
page.tsxto import and render the newExecGridcomponent, replacing the previous placeholder content. [1] [2]#49