fixing the logon form driver bug#79
Open
json0130 wants to merge 1 commit into
Open
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Update LogonForm.tsx, so the logon form checks if the driver is selected. Because it used to be allow you to submit without selecting the driver.
Closes
What Changed?
Previously, by default, it checked if the array was non-empty or not. However, I added the extra boolean variable to check if the user has selected the driver or not.
How To Review
Try to submit the logon form without selecting the driver; it will not allow you to submit it.
Notes
Now it would be nice if it automatically navigates to the driver section when the user is trying to submit the logon form without selecting the driver.