feat(membership-registration): add form data parser#45
Open
bds165 wants to merge 2 commits into
Open
Conversation
Contributor
bds165
commented
May 8, 2026
bds165
commented
- Added parseRegistrationFormData to parse raw membership registration FormData into a plain object.
WilliamTayNZ
requested changes
May 11, 2026
Collaborator
WilliamTayNZ
left a comment
WilliamTayNZ
left a comment
There was a problem hiding this comment.
Parser looks good overall, helper functions are good.
There are just a few fields missing, see schema.prisma
Nitpick comment: prefer no empty line between potentialInvolvement and discordUsername
Good work.
Collaborator
|
also change |
Contributor
Author
|
Renamed Added: Removed blank line between |
WilliamTayNZ
requested changes
May 14, 2026
| return { | ||
| firstName: getTextField(formData, "firstName"), | ||
| lastName: getTextField(formData, "lastName"), | ||
| email: getTextField(formData, "email"), |
Collaborator
There was a problem hiding this comment.
one final thing: we should normalise the email and UPI to be lower case.
after that we can merge 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.