Conversation
| <form | ||
| className="flex flex-col gap-4" | ||
| onSubmit={(e) => e.preventDefault()} | ||
| > |
There was a problem hiding this comment.
question: do we need to submit data here?
| const [fullName, setFullName] = useState("") | ||
| const [email, setEmail] = useState("") | ||
| const [password, setPassword] = useState("") |
There was a problem hiding this comment.
question: consider what happens if the user leaves the page for a bit, will they be able to keep their data?
There was a problem hiding this comment.
There are good libraries for handling this like https://react-hook-form.com/
| value={password} | ||
| onChange={(e) => setPassword(e.target.value)} | ||
| placeholder="Example Password" | ||
| autoComplete="current-password" |
There was a problem hiding this comment.
question: do we want users to sign up with a current password or a new password - this is a sign up page
| <style>{styles}</style> | ||
| <div | ||
| className={`grad-border p-15 max-w-md w-full shadow-lg ${className}`} | ||
| style={{ | ||
| backgroundColor: "rgba(185, 213, 255, 0.25)", | ||
| backdropFilter: "blur(12px)", | ||
| }} |
There was a problem hiding this comment.
nit: it is an anti-pattern to mix tailwind styling and inline css/style tags, consider defining the styles you need in the globals.css file OR look up the relevant tailwind alternatives
There was a problem hiding this comment.
concatenating classname like:
`grad-border p-15 max-w-md w-full shadow-lg ${className}`
can lead to unexpected errors, consider using the cn() function in client/utils like:
cn("grad-border p-15 max-w-md w-full shadow-lg", className)which will handle any edge cases
There was a problem hiding this comment.
^ requires your branch to be up to date with main branch
There was a problem hiding this comment.
Looks good generally, also I'd recommend taking a quick read in conventional commits.
https://www.conventionalcommits.org/en/v1.0.0/
I noticed that a couple commit messages are recommended to be labeled as a different type such as:
feat: ran prettier(should bestyle: ...)ran prettier->run prettier(no past tense in description)
There was a problem hiding this comment.
question: a signup page already exists, are you sure this page is still needed?
existing signup page:
sign-up page in this PR:
7 participants
Description
implemented the styling for portal page
Fixes # (issue)
Type of change
How Has This Been Tested?
Checklist before requesting a review