Open
Conversation
96a4a5b to
579c131
Compare
437f176 to
437f852
Compare
Author
|
Could someone please review and approve? Without this fix unstructured will not work on windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
layout.py
Is creating a
NamedTemporaryFile. On Windows, when you create a NamedTemporaryFile, the file is opened with an exclusive lock by default. This means that no other process can open the file while it is being used by the process that created it.Up the stack, pdf2image's
convert_from_pathis being invoked, which uses the system poppler installation to gather information about the pdf. Because poppler is a separate process, this results in an error.