Merged
Conversation
Bump to version 1.0.0 as it is now feature comparable with its Polyscope 5 sister
urfeex
reviewed
Jun 24, 2025
| raise Exception(f"Did not receive any script lines") | ||
| return program | ||
| except Exception as e: | ||
| raise Exception(f"Connectivity problem to with {self.robotIP}:{self.port}: {e}") No newline at end of file |
Member
There was a problem hiding this comment.
I always run into this when trying this against the ur_robot_driver. With this fetch you assume that the server sends an empty message after it has sent the data. I'm not sure whether we currently do that in the client_library.
In the Java URCap we use buff.ready() to check whether the data transfer is done.
urfeex
requested changes
Jun 24, 2025
Member
urfeex
left a comment
urfeex
left a comment
There was a problem hiding this comment.
The timeout mechanism doesn't work with the client_library's script sender, I've made a suggestion that works.
Co-authored-by: Felix Exner <feex@universal-robots.com>
urfeex
approved these changes
Jun 24, 2025
Member
urfeex
left a comment
urfeex
left a comment
There was a problem hiding this comment.
Tested it and works as expected now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Multinode support
Bump to version 1.0.0 as it is now feature comparable with its PolyScope 5 sister