-
Notifications
You must be signed in to change notification settings - Fork 15
Update unique to polkadot 2509 #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| type CheckAssociatedRelayNumber = pallet_configuration::CheckAssociatedRelayNumber<Self>; | ||
| type ConsensusHook = ConsensusHookWrapper; | ||
| type SelectCore = cumulus_pallet_parachain_system::DefaultCoreSelector<Runtime>; | ||
| type RelayParentOffset = ConstU32<0>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это что-то для async-backing на стороне реле?..
The offset between the tip of the relay chain and the parent relay block used as parent when authoring a parachain block.
This setting directly impacts the number of descendant headers that are expected in the set_validation_data inherent.
For any setting N larger than zero, the inherent expects that the inherent includes the relay parent plus N descendants. These headers are required to validate that new parachain blocks are authored at the correct offset.
While this helps to reduce forks on the parachain side, it increases the delay for processing XCM messages. So, the value should be chosen wisely.
If set to 0, this config has no impact.
В cumulus yet-another-parachain стоит
/// Build with an offset of 1 behind the relay chain.
const RELAY_PARENT_OFFSET: u32 = 1;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А, стоп, это для elastic scaling:
Понять бы смысл, возможно нам стоит это включить на случай появления elastic scaling на реле?
Cc: @mrshiposha (Вроде он что-то про elastic-scaling слышал, я пока не особо читал как оно должно работать)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А это нам полезно по идее, это не от elastic scaling, а просто как новая опция async-backing
async-backing позволяет парачейну производить блоки позже, используя старые блоки реле
Если нам не так сильно нужна скорость XCM, то можно поставить offset чтобы парачейну нужно было реже свои форки делать, в тестах они у нас очень часто происходят
| .saturating_add(T::DbWeight::get().writes(1_u64)) | ||
| } | ||
|
|
||
| fn weigh_message() -> Weight { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
У нас есть какой-то бенчмарк для этого? Я не очень понимаю откуда эти веса вообще берутся и зачем нужны
Cc: @mrshiposha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Да, он находится в polkadot-sdk
9a8ded6 to
5cbd516
Compare
No description provided.