Skip to content

fix version comparison#1474

Open
ocefpaf wants to merge 2 commits intoUnidata:masterfrom
ocefpaf:fix_version_string_comparison
Open

fix version comparison#1474
ocefpaf wants to merge 2 commits intoUnidata:masterfrom
ocefpaf:fix_version_string_comparison

Conversation

@ocefpaf
Copy link
Collaborator

@ocefpaf ocefpaf commented Mar 2, 2026

With the release of 4.10.0 this evaluates to False instead of True. We already depend on packaging, so using Version this should not be problem.

Correction, it was a test only dependency. If we do not want top make it a run time dependency we can implement our own version check there. (I prefer packaging.Version though.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant