fix: remove commits-only guard in GoalTracker auto-sync (closes #2410)#2425
Open
Rudrasamadhiya wants to merge 1 commit into
Open
fix: remove commits-only guard in GoalTracker auto-sync (closes #2410)#2425Rudrasamadhiya wants to merge 1 commit into
Rudrasamadhiya wants to merge 1 commit into
Conversation
GSSoC Label Checklist 🏷️@Umbrella-io — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
GoalTrackercomponent's auto-sync logic silently skipped all goal types exceptunit === "commits". This meant streak, PR, review, and other goal types never triggered background sync, leaving them perpetually stale.This fix removes the guard clause
if (g.unit !== "commits") return false;and replaces it with a comment clarifying that auto-sync applies to all goal types.Closes #2410
Type of Change