Cura 13207 get diff#54
Open
HellAholic wants to merge 6 commits into
Open
Conversation
We are using the get diff in different workflows and the output of the new reusable workflow needs to be prepared for consumption. This also switches the approach from github env to github output.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a first-party composite GitHub Action (.github/actions/get-diff) to standardize how reusable workflows in this repo determine which files changed, and updates the existing linting workflows to use the new action outputs instead of the previous third-party diff action.
Changes:
- Added a new composite action
.github/actions/get-diffthat filters changed files by glob patterns and exports them as step outputs. - Updated
lint-tidierandlint-formatterreusable workflows to consume the new action outputs (files,files_quoted) and simplified workflow logic accordingly. - Fixed the
platisd/clang-tidy-pr-commentsaction reference to include thevtag prefix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/actions/get-diff/action.yml | Adds the new composite action for changed-file detection and exporting outputs. |
| .github/workflows/lint-tidier.yml | Switches clang-tidy workflow to use the new get-diff action and fixes action version tag. |
| .github/workflows/lint-formatter.yml | Switches formatting workflow to use the new get-diff outputs and removes the conversion step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new Action (
get-diff) for detecting changed files in workflows. It updates the linting workflows to use this new action, improving consistency and maintainability. The main changes include adding the new action, updating workflow steps to use its outputs, and making minor improvements to workflow logic. It utilizes a public action and formats the output for consumption.Introduction of custom get-diff action:
.github/actions/get-diff/action.yml, a composite action that detects changed files based on glob patterns, supports inclusion of deleted files, and exposes outputs for downstream workflow steps.bugfix
platisd/clang-tidy-pr-commentsin thelint-tidier(missing v)CURA-13207