fix: prevent OOM in analyze files tool for large attachments#667
Draft
cotovanu-cristian wants to merge 1 commit intomainfrom
Draft
fix: prevent OOM in analyze files tool for large attachments#667cotovanu-cristian wants to merge 1 commit intomainfrom
cotovanu-cristian wants to merge 1 commit intomainfrom
Conversation
The analyze files tool loaded entire files into memory eagerly and base64-encoded them, causing peak memory to spike to multiple times the file size (raw bytes + base64 bytes + JSON serialization + trace payload). On serverless machines with 1GB limits, a 50MB PDF could trigger OOM through these multiplicative copies. Changes: - Add a 15MB file size limit with early rejection via Content-Length header check and streaming size validation - Stream downloads to a temp file instead of buffering in memory, reducing peak heap usage during base64 encoding - Process multiple file attachments sequentially instead of with asyncio.gather() to avoid concurrent memory spikes - Explicitly free raw bytes before string conversion to minimize peak memory during encoding Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The analyze files tool loaded entire files into memory eagerly and base64-encoded them, causing peak memory to spike to multiple times the file size (raw bytes + base64 bytes + JSON serialization + trace payload). On serverless machines with 1GB limits, a 50MB PDF could trigger OOM through these multiplicative copies.
Changes: