docs(uipath-platform): revert --all-fields PascalCase note#643
Open
docs(uipath-platform): revert --all-fields PascalCase note#643
Conversation
PR #612 (merged) added a note saying `--all-fields` returns PascalCase keys, matching the curated casing convention. The corresponding CLI change was reverted in cli/PR#1884 (the helper sat under core-cli ownership and the cross-team approval requirement wasn't worth the casing-consistency win), so `--all-fields` returns raw camelCase API DTO again. Drop the now-inaccurate note. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Claude finished @alexenica's task in 1m 26s —— View job Review: PR #643
SummarySingle-line revert in Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | Not modified |
| E2E Tests | OK | Doc-only revert, no behavioral change |
| Skill Body | OK | Not modified |
| References & Assets | Issue | uip-commands.md has a stale PascalCase reference from the same PR |
| Repo Hygiene | OK | Scoped change, no secrets, no cross-skill refs |
Issues for Manual Review
- Confirm whether
--all-fieldsscope is still "Orchestrator tool only" (as inuip-commands.md) or "Orchestrator tool + libraries" (as it was before docs(uipath-platform): expand deploy-config workflow + CLI 1.0 / solution skill sync #612). Theresources.mdchanges from docs(uipath-platform): expand deploy-config workflow + CLI 1.0 / solution skill sync #612 removed--all-fieldsfrom library commands — verify whether that removal was also reverted upstream.
Conclusion
The orchestrator.md change is correct and clean. However, the same PascalCase language from PR #612 survives in uip-commands.md:14-16 and should be reverted for consistency. Recommend fixing that before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #612 added a note to `orchestrator.md`'s common-flags table claiming `--all-fields` returns PascalCase keys end-to-end. The corresponding CLI change (cli/PR#1884) was reverted — the `toPascalCaseKeys` helper lived under `@uipath/common` which is default-owned by `@UiPath/core-cli` per CODEOWNERS, and the cross-team approval requirement wasn't worth the casing-consistency win.
`--all-fields` is back to its prior behavior (raw camelCase API DTO). Drop the inaccurate note.
Test plan
🤖 Generated with Claude Code