fix(hitl): align flow plugin hitl/impl.md with CLI contract#642
fix(hitl): align flow plugin hitl/impl.md with CLI contract#642dushyant-uipath wants to merge 1 commit intomainfrom
Conversation
- Remove spurious action: "Continue"/"End" from QuickForm outcomes example (not written by addHitlNode; already removed from hitl-node-quickform.md in #627 but missed here) - Strip description fields from node instance outputs (not generated by CLI) - Add per-field outputs entry with custom: true to the Quick Reference JSON and document $vars.<variable> as a workflow-global variable - Fix status description from "action value" to "outcome id"
|
Claude finished @dushyant-uipath's task in 2m 5s —— View job Review: PR #642
SummaryFixes four stale fields in Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | N/A | No frontmatter changes |
| E2E Tests | N/A | Documentation-only fix, no new behavior |
| Skill Body | N/A | Changes are in a reference file |
| References & Assets | OK | All four fixes are accurate and well-scoped |
| Repo Hygiene | OK | No secrets, no cross-skill deps introduced, all links resolve |
Issues for Manual Review
- Confirm that
=result.Actionstill resolves to the outcomeid(e.g."approve") rather than some other field — the PR's description says "outcome id" which matches the outcome objects'idvalues, but this is a domain-specific runtime behavior the reviewer cannot verify statically.
Conclusion
Clean, well-scoped fix. All four changes bring impl.md into alignment with the CLI contract and the previously-fixed hitl-node-quickform.md. Only a minor placeholder case note (Low). Approve.
Summary
Alignment fixes in
skills/uipath-maestro-flow/references/author/references/plugins/hitl/impl.md:action: "Continue"/"End"from QuickForm outcomes example (was removed fromhitl-node-quickform.mdin fix(hitl): remove spurious action field from outcomes, add globals variable discovery #627 but missed here)descriptionfields from node instanceoutputs(not generated by CLI; lives in definition'soutputDefinition, not the instance)custom: trueentry to the Quick Reference outputs JSON and document$vars.<variable>as a workflow-global variable path$vars.{nodeId}.statusdescription from "action value" to "outcome id" (returns e.g."approve", not"Continue")Background
Corresponds to uipcli PR #1894 (HITL
node.outputsfix). The Quick Reference node JSON was showing stale fields that the CLI does not write, causing divergence between what the skill documents and what the actual.flowfile contains.Test plan
impl.mdno longer haveactionfieldoutputsblock matches CLI output formatstatusvariable description correctly says "outcome id"