Skip to content

fix(hitl): add date field guidance and DevCon vendor approval test#534

Open
dushyant-uipath wants to merge 1 commit intomainfrom
fix/hitl-date-docs-devcon-test
Open

fix(hitl): add date field guidance and DevCon vendor approval test#534
dushyant-uipath wants to merge 1 commit intomainfrom
fix/hitl-date-docs-devcon-test

Conversation

@dushyant-uipath
Copy link
Copy Markdown
Collaborator

Summary

  • hitl-node-quickform.md — adds Date field notes block documenting ISO 8601 format requirement, the design-time "Invalid time value" rendering limitation, and the rule to coerce to YYYY-MM-DD string before binding
  • e2e_08_vendor_approval_devcon.yaml — new E2E test mirroring the DevCon vendor onboarding demo: risk-based routing (switch), multiple HITL reviewers, vague prompt that agent must interpret

Test plan

  • CI passes on this branch
  • Verify e2e_08 runs cleanly in skills test harness

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Claude finished @dushyant-uipath's task in 1m 52s —— View job


PR Review: fix(hitl): add date field guidance and DevCon vendor approval test

  • Gather context (review criteria, diff, existing comments)
  • Read full changed files
  • Apply skill-specific and content quality checks
  • Post review findings

Summary

Adds a 5-line "Date field notes" block to the HITL QuickForm reference documenting ISO 8601 format requirements and a design-time rendering quirk, plus a new E2E test (e2e_08) modeling the DevCon vendor onboarding demo with risk-based routing and multiple HITL reviewers.

Change-by-Change Review

1. skills/uipath-human-in-the-loop/references/hitl-node-quickform.md (+5 lines)

Severity: Low

The date field notes are accurate and well-placed between "Supported field types" and "Design rules." The "Invalid time value" callout is valuable — it prevents agents from debugging a non-issue at design time.

Minor token-optimization nit (lines 66–67): the phrase "is a known rendering limitation" could be compressed per .claude/rules/token-optimization.md. For example:

- **"Invalid time value" at design time** — known rendering limitation. When `binding` is a JS expression …

This is cosmetic — the current wording is clear and not bloated.

2. tests/tasks/uipath-human-in-the-loop/e2e_08_vendor_approval_devcon.yaml (new, +118 lines)

Severity: OK

Well-structured test. Specifics:

  • task_id: skill-hitl-e2e-vendor-approval-devcon — matches skill-<domain>-<capability> pattern. ✓
  • tags: [uipath-human-in-the-loop, e2e, green-field, vendor-approval, risk-routing, devcon] — skill name first, valid test type second, descriptive tags after. Matches convention from e2e_01 through e2e_07. ✓
  • initial_prompt: Describes the business goal without prescribing steps. Intentionally vague to test skill guidance. ✓
  • success_criteria: 7 checks covering validation, node type presence, switch routing, handle wiring, report.json structure, and command execution. Comprehensive. ✓
  • sandbox/agent config: driver: tempdir, python: {}, max_turns: 75, turn_timeout: 1200 — matches existing e2e conventions. ✓
  • No secrets or personal paths.

What's Missing

Nothing identified.

Area Ratings

Area Status Notes
Frontmatter N/A No SKILL.md changes
E2E Tests OK New e2e test follows conventions; smoke/e2e coverage already exists
Skill Body N/A No SKILL.md changes
References & Assets OK Date field notes are accurate and well-placed
Repo Hygiene OK CODEOWNERS present, no secrets, changes scoped to HITL skill

Issues for Manual Review

  • Domain accuracy: the claim that non-ISO date formats "will not parse" and that "Invalid time value" is strictly display-only — worth confirming against the current Maestro runtime, as behavior could differ across versions.

Conclusion

Clean PR. Both changes are well-scoped, follow existing conventions, and add genuine value (preventing a common date-field confusion, and adding coverage for the flagship DevCon scenario). No blocking issues. The single Low finding on prose compression is optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant