fix(hitl): add date field guidance and DevCon vendor approval test#534
fix(hitl): add date field guidance and DevCon vendor approval test#534dushyant-uipath wants to merge 1 commit intomainfrom
Conversation
|
Claude finished @dushyant-uipath's task in 1m 52s —— View job PR Review: fix(hitl): add date field guidance and DevCon vendor approval test
SummaryAdds a 5-line "Date field notes" block to the HITL QuickForm reference documenting ISO 8601 format requirements and a design-time rendering quirk, plus a new E2E test ( Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | N/A | No SKILL.md changes |
| E2E Tests | OK | New e2e test follows conventions; smoke/e2e coverage already exists |
| Skill Body | N/A | No SKILL.md changes |
| References & Assets | OK | Date field notes are accurate and well-placed |
| Repo Hygiene | OK | CODEOWNERS present, no secrets, changes scoped to HITL skill |
Issues for Manual Review
- Domain accuracy: the claim that non-ISO date formats "will not parse" and that "Invalid time value" is strictly display-only — worth confirming against the current Maestro runtime, as behavior could differ across versions.
Conclusion
Clean PR. Both changes are well-scoped, follow existing conventions, and add genuine value (preventing a common date-field confusion, and adding coverage for the flagship DevCon scenario). No blocking issues. The single Low finding on prose compression is optional.
Summary
hitl-node-quickform.md— adds Date field notes block documenting ISO 8601 format requirement, the design-time "Invalid time value" rendering limitation, and the rule to coerce toYYYY-MM-DDstring before bindinge2e_08_vendor_approval_devcon.yaml— new E2E test mirroring the DevCon vendor onboarding demo: risk-based routing (switch), multiple HITL reviewers, vague prompt that agent must interpretTest plan
e2e_08runs cleanly in skills test harness