Skip to content

docs(uipath-rpa): fix Terminal activity XAML examples#532

Merged
gabrielavaduva merged 1 commit intomainfrom
docs/activity-docs/terminal-fixes
May 7, 2026
Merged

docs(uipath-rpa): fix Terminal activity XAML examples#532
gabrielavaduva merged 1 commit intomainfrom
docs/activity-docs/terminal-fixes

Conversation

@bogdangasparup
Copy link
Copy Markdown
Collaborator

  • Replace incorrect namespace prefixes (t:, ta:) with uit: across all 20 activity docs
  • Add missing WaitType and DelayMS properties to every XAML example
  • Add constructor-defaulted properties (CloseConnection, TimeoutMS, DelayMS) to TerminalSession examples

- Replace incorrect namespace prefixes (`t:`, `ta:`) with `uit:` across all 20 activity docs
- Add missing `WaitType` and `DelayMS` properties to every XAML example
- Add constructor-defaulted properties (`CloseConnection`, `TimeoutMS`, `DelayMS`) to TerminalSession examples

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Claude finished @bogdangasparup's task in 1m 59s —— View job


PR Review: docs(uipath-rpa): fix Terminal activity XAML examples

  • Gather context (read review criteria, diff, existing comments)
  • Read full changed files for surrounding context
  • Apply review checks (structure, consistency, correctness, links)
  • Post review findings

Summary

Fixes incorrect XML namespace prefixes (t:, ta:) → uit: across all 20 Terminal activity docs, and adds missing WaitType/DelayMS properties to every XAML example. TerminalSession examples also gain constructor-defaulted CloseConnection, TimeoutMS, and DelayMS properties.

Change-by-Change Review

1. Namespace prefix fix (t:/ta:uit:) — all 20 files

Severity: OK

All files now consistently use uit: as the namespace prefix. No old t: or ta: prefixes remain anywhere in the Terminal activity docs. The fix is applied uniformly and completely.

2. WaitType and DelayMS added to child activity XAML examples — 19 files

Severity: OK

Every child activity XAML example now includes WaitType and DelayMS. Values match the documented defaults in each file's property table:

  • Most activities: DelayMS="300", WaitType="READY"
  • SendControlKey.md: DelayMS="1000" (matches its documented default of 1000) ✓
  • WaitScreenReady.md: DelayMS="0" (matches its documented default of 0, noted in the Notes section) ✓

3. TerminalSession.md — constructor-defaulted properties added

Severity: OK

  • Mode A (new connection): Added CloseConnection="True" and DelayMS="1000" alongside existing TimeoutMS="50000". All values match the property table defaults.
  • Mode B (existing connection): Added TimeoutMS="50000" and DelayMS="1000". CloseConnection="False" was already present (intentional override for reuse mode). Inner t:TerminalSession.Body, x:TypeArguments, and DelegateInArgument references also correctly updated to uit:.

What's Missing

Nothing identified.

Area Ratings

Area Status Notes
Frontmatter N/A No frontmatter changes
E2E Tests N/A Doc-only fix to existing reference files — no new capabilities
Skill Body N/A SKILL.md not modified
References & Assets OK All 20 Terminal activity docs corrected consistently
Repo Hygiene OK Changes scoped to Terminal activity docs only, no secrets, no cross-skill refs

Issues for Manual Review

  • Domain accuracy: The uit: namespace prefix and inclusion of WaitType/DelayMS as required XAML attributes should be verified against actual UiPath Studio-generated XAML for UiPath.Terminal.Activities 2.10. The changes are internally consistent but correctness depends on the actual runtime contract.

Conclusion

Clean, mechanical fix applied uniformly across all 20 files. Namespace prefixes are now consistent, and XAML examples include the full set of properties that match their documented defaults. No issues found — approve.


```xml
<ta:TerminalFindTextInScreen DisplayName="Find Text"
<uit:TerminalFindTextInScreen DisplayName="Find Text"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexandru-petre fyi - I think this change should be ported to the activities repo.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is already merged in the activities repo but I wanted it here as well

@gabrielavaduva gabrielavaduva merged commit 46793fa into main May 7, 2026
11 of 12 checks passed
@gabrielavaduva gabrielavaduva deleted the docs/activity-docs/terminal-fixes branch May 7, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants