feat(apollo-vertex): onboarding tour — step popover and type definitions#674
Open
petervachon wants to merge 1 commit intomainfrom
Open
feat(apollo-vertex): onboarding tour — step popover and type definitions#674petervachon wants to merge 1 commit intomainfrom
petervachon wants to merge 1 commit intomainfrom
Conversation
petervachon
requested review from
0xr3ngar and
ruudandriessen
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 tasks
petervachon
force-pushed
the
feat/vertex-onboarding-tour-joyride
branch
from
ce9dc19 to
a795087
Compare
github-actions
Bot
added
size:L
Dependency License Review
License distribution
Excluded packages
|
petervachon
force-pushed
the
feat/vertex-onboarding-tour-joyride
branch
from
a795087 to
92ab801
Compare
…ypes Adds the presentational layer of the onboarding-tour-joyride registry component: step type definitions, tour persistence hook, and the popover card that Joyride renders as its tooltipComponent. The popover card is split into two components: OnboardingTourJoyridePopoverCard (pure visual, usable standalone for static previews) and OnboardingTourJoyridePopover (adapter that receives Joyride's TooltipRenderProps and feeds them into the card). This keeps the presentational component free of Joyride's internal prop types. Co-Authored-By: Colin Reilly <colin.reilly@gmail.com>
petervachon
force-pushed
the
feat/vertex-onboarding-tour-joyride
branch
from
92ab801 to
a525709
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First in a 3-part stack that adds a guided onboarding tour component
to Apollo Vertex. This slice lays the foundation: the step popover
card that highlights UI elements and walks users through a feature,
plus the type system and persistence that all three slices share.
When this stack is complete, product teams can drop an onboarding tour
into any Apollo-based app with a single shadcn install — defining their
own steps, selectors, and welcome screens without writing tour
infrastructure from scratch.
This PR intentionally ships no visible behavior. It exists so the
popover design and component API can be reviewed and signed off before
the orchestration layer (PR 2) and docs (PR 3) build on top of it.
What's included
their tour steps, placements, and conditional gating
highlighted elements during a tour
so they don't see the same tour twice
What's next
renders the welcome modal
Test plan
pnpm --filter apollo-vertex buildpassespnpm --filter apollo-vertex lintpasses🤖 Generated with Claude Code