Haidy's theme exploration - glass light theme - DO NOT MERGE#270
Haidy's theme exploration - glass light theme - DO NOT MERGE#270hfrancis31 wants to merge 1 commit intomainfrom
Conversation
hfrancis31
requested review from
0xr3ngar,
alincadariu,
angeloaltamiranom,
frankkluijtmans and
ruudandriessen
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| // --------------------------------------------------------------------------- | ||
|
|
||
| /** Standard glass card — fully rounded */ | ||
| const glassCard = [ |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // --------------------------------------------------------------------------- | ||
|
|
||
| /** Standard glass card — fully rounded */ | ||
| const glassCard = [ |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 days ago
To fix the problem, we should either use glassCard somewhere meaningful or remove it entirely. Since the warning is about an unused variable and we must avoid altering existing behavior, the safest fix is to delete the unused constant definition rather than introduce new usages that might change the UI.
Concretely, in apps/apollo-vertex/templates/HaidyThemeLoanQC.tsx, remove the definition of glassCard (lines 21–28) including its JSDoc comment and the array/join construction. No other code depends on it according to the analysis, so no additional imports or helper functions are necessary. The surrounding code (imports, glassSidebar, and the memo data objects) should remain unchanged.
| @@ -18,15 +18,6 @@ | ||
| // Shared glass styles (accessible — all text ≥ 4.5:1 on ~#eff3f7) | ||
| // --------------------------------------------------------------------------- | ||
|
|
||
| /** Standard glass card — fully rounded */ | ||
| const glassCard = [ | ||
| "rounded-2xl", | ||
| "bg-white/50", | ||
| "backdrop-blur-[20px]", | ||
| "border border-white/70", | ||
| "shadow-[0_0_0_1px_rgba(255,255,255,0.7),0_0_48px_-2px_rgba(185,205,230,0.45),0_0_28px_0_rgba(220,232,245,0.30),0_0_12px_0_rgba(255,255,255,0.25),inset_0_2px_20px_0_rgba(255,255,255,0.60),inset_0_-1px_6px_0_rgba(200,215,235,0.12)]", | ||
| ].join(" "); | ||
|
|
||
| /** Left sidebar — no rounding, flush to left edge, right border acts as divider */ | ||
| const glassSidebar = [ | ||
| "rounded-none", |
1 participant
No description provided.