Conversation
petervachon
requested review from
0xr3ngar,
alincadariu,
angeloaltamiranom,
frankkluijtmans and
ruudandriessen
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import { | ||
| CheckCircle, | ||
| Clock, | ||
| FileText, | ||
| AlertTriangle, | ||
| TrendingUp, | ||
| } from "lucide-react"; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 days ago
To fix the unused import, remove AlertTriangle from the destructuring import list from lucide-react. This keeps the remaining icons intact and does not affect existing functionality, since AlertTriangle is not referenced anywhere in the provided code.
Concretely, in apps/apollo-vertex/app/(preview)/preview/shell/invoice-dashboard.tsx, edit the import { ... } from "lucide-react"; block at the top of the file and delete the AlertTriangle, entry, leaving the other imports unchanged. No additional methods, definitions, or imports are required.
| @@ -4,7 +4,6 @@ | ||
| CheckCircle, | ||
| Clock, | ||
| FileText, | ||
| AlertTriangle, | ||
| TrendingUp, | ||
| } from "lucide-react"; | ||
| import { Badge } from "@/components/ui/badge"; |
| TooltipProvider, | ||
| TooltipTrigger, | ||
| } from "@/components/ui/tooltip"; | ||
| import { cn } from "@/lib/utils"; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 days ago
In general, unused imports should be removed to keep the codebase clean and avoid confusion. Since cn is not referenced anywhere in apps/apollo-vertex/registry/shell/shell-company.tsx, the best fix is simply to delete the named import cn from "@/lib/utils".
Concretely, in apps/apollo-vertex/registry/shell/shell-company.tsx, remove line 13:
import { cn } from "@/lib/utils";No other code changes, additional methods, or imports are needed. This does not change any existing functionality because cn was not used.
| @@ -10,7 +10,6 @@ | ||
| TooltipProvider, | ||
| TooltipTrigger, | ||
| } from "@/components/ui/tooltip"; | ||
| import { cn } from "@/lib/utils"; | ||
| import { useLocalStorage } from "@/registry/use-local-storage/use-local-storage"; | ||
| import type { CompanyLogo } from "./shell"; | ||
| import { |
| const { t, i18n } = useTranslation(); | ||
| const { user } = useUser(); | ||
| const { logout } = useAuth(); | ||
| const { theme, setTheme } = useTheme(); |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 days ago
In general, unused variables should be removed or, if they are meant to be used, the code should be updated to actually use them. Here, useTheme() returns at least { theme, setTheme }, but only setTheme is needed for behavior (e.g., toggling dark/light mode). To avoid changing existing functionality, we should simply stop binding theme without altering how setTheme is used.
Specifically, in apps/apollo-vertex/registry/shell/shell-user-profile.tsx, update the destructuring assignment on line 55 from const { theme, setTheme } = useTheme(); to const { setTheme } = useTheme();. No additional imports or definitions are required, and no other lines need to change, assuming theme is not referenced elsewhere in the file.
| @@ -52,7 +52,7 @@ | ||
| const { t, i18n } = useTranslation(); | ||
| const { user } = useUser(); | ||
| const { logout } = useAuth(); | ||
| const { theme, setTheme } = useTheme(); | ||
| const { setTheme } = useTheme(); | ||
| const [language, setLanguageState] = useState(i18n.language); | ||
|
|
||
| const setLanguage = useCallback((code: string) => { |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| import { | ||
| CheckCircle, | ||
| Clock, | ||
| FileText, | ||
| AlertTriangle, | ||
| TrendingUp, | ||
| } from "lucide-react"; |
| TooltipProvider, | ||
| TooltipTrigger, | ||
| } from "@/components/ui/tooltip"; | ||
| import { cn } from "@/lib/utils"; |
| const { t, i18n } = useTranslation(); | ||
| const { user } = useUser(); | ||
| const { logout } = useAuth(); | ||
| const { theme, setTheme } = useTheme(); |
petervachon
changed the title
1 participant
Need to create a preview link for review by design team. Will indicate when it's ready to be merged