Cleanup appeal sorting, improve appeal list styling

[supertassu]

Reviewing with whitespace changes ignored is recommended. (Files changed -> click gear icon -> enable "Hide whitespace changes" -> apply)

• Fix some appeals appearing twice (closes Reserved appeals in wrong section #232)
• Cleanup code style in AppealController. I checked the raw SQL queries being executed weren't modified (except fixing Reserved appeals in wrong section #232)
• Cleanup formatting and code style in appeal list. Notably changes dark background to light, uses table formatting instead of bg-* classes, adds reserving admin to list. See screenshots:

Current

New

[pull-assistant]

Best reviewed: commit by commit

---

Optimal code review plan (1 warning)

     Cleanup appeal sorting, improve appeal list styling

     Fix formatting, thanks PhpStorm

Make links on table bold and dark to improve a11y

...s/appeals/appeallist.blade.php 50% changes removed in Keep darkness, just ...

     Keep darkness, just change primary/warning bg to dark

     Merge branch 'master' into cleanup-appeal-list-formatting

     Merge branch 'master' into cleanup-appeal-list-formatting

     Merge branch 'master' into cleanup-appeal-list-formatting

Powered by Pull Assistant. Last update b06f800 ... 63c3a9c. Read the comment docs.

[dqwiki]

I'm concerned that the color changes are not assisting in our accessibility by not having a sufficient contrast ratio. The original colors were chosen for that reason. There is still an issue currently with blue and yellow rows having proper contrast ratio, but this new option now makes every URL pop up with an accessibility issue.

For people I know either directly or indirectly, the new colors pose more of a struggle to use, and it creates even more white-space (which we already have enough of).

This is why I initially rejected it in the last review.

[supertassu]

How about this:

Screenshot

It still keeps the link colors and dark background but makes the backgrounds less flashy.

[dqwiki]

Everything but the yellow seems to stand out enough.

[supertassu]

New screenshot: