Skip to content

Uniffi API mismatach followup#8

Merged
txalkan merged 2 commits intoUTEXO-Protocol:devfrom
rmn-boiko:fix/uniffi-mismatch-follow-up
Apr 6, 2026
Merged

Uniffi API mismatach followup#8
txalkan merged 2 commits intoUTEXO-Protocol:devfrom
rmn-boiko:fix/uniffi-mismatch-follow-up

Conversation

@rmn-boiko
Copy link
Copy Markdown
Collaborator

@rmn-boiko rmn-boiko commented Mar 31, 2026

  • Added full UniFFI SDK surface for RLN (UDL, UniFFI API layer, SDK module, exposed types, and lifecycle state bridge).
  • Added UniFFI binding infrastructure and automation (build.rs, UniFFI configs, bindgen helper crate, generation scripts for Python/Kotlin/Swift/Android, CI artifact workflow).
  • Added SDK-facing documentation and Python interop example covering node init/unlock/funding, UTXO creation, asset issuance, channel open, invoice creation, payment send, and status checks.
  • Introduced supporting library/test structure updates to run SDK logic as a library and validate UniFFI behavior.
  • Aligned UniFFI payment model with backend by adding preimage propagation end-to-end (SDK data -> UniFFI mapping -> exported type -> UDL).
  • Expanded UniFFI API error mapping to cover a broader set of backend errors with consistent RlnError categories (NotFound / Conflict / InvalidRequest / Internal).
  • Added tests validating the updated error mapping behavior and payment preimage mapping correctness.

gofman8
gofman8 previously approved these changes Mar 31, 2026
@gofman8 gofman8 requested a review from txalkan March 31, 2026 13:12
@MaiborodaY
Copy link
Copy Markdown
Collaborator

MaiborodaY commented Mar 31, 2026

Retested locally after merging the PR.

Confirmed fixed:

  • Kotlin openchannel_optional_addr_forward now passes
  • Kotlin openchannel_optional_addr_reverse now passes
  • Python openchannel_fail_no_utxos now passes
  • lib_sdk::payment::success passes with Payment.preimage validated as well

So the previously found UniFFI error-mapping gaps are now resolved on my side, and the Payment.preimage follow-up also looks good.

@txalkan
Copy link
Copy Markdown
Collaborator

txalkan commented Apr 1, 2026

Hi Roman, pls remember to add PR descriptions.

We can approve this PR after #9 is merged and the merge conflicts are resolved. Thank you

@rmn-boiko rmn-boiko requested a review from gofman8 April 2, 2026 11:23
MaiborodaY added a commit to MaiborodaY/rgb-lightning-node that referenced this pull request Apr 2, 2026
@txalkan txalkan requested a review from MaiborodaY April 3, 2026 13:17
@gofman8
Copy link
Copy Markdown

gofman8 commented Apr 6, 2026

@rmn-boiko let's merge

@txalkan txalkan merged commit 9aa39ce into UTEXO-Protocol:dev Apr 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants