Add more statuses to for the grade loader #92 #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@SoggyRhino yeah the |
mikehquan19
approved these changes
Oct 28, 2025
Contributor
mikehquan19
left a comment
mikehquan19
left a comment
There was a problem hiding this comment.
lgtm. Thanks! Will update the db with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I felt like expanding the original approach to include "P", "CR", "NC", "I", "NF" would have been obnoxious so I changed to a map based approach.
"W", "P", "CR", "NC", "I", "NF" do not consistently appear between semesters so they are all optional and not guaranteed (just as W was before).
Some of the older semesters have an NF column so I included that as well. I have no idea what it stands for though so let me know if it should be removed or combined with another column.
The order is the same as the original but with the new grades added to the end. This means that all of the indexes on the front end should still work.
Old:
"A+", "A", "A-", "B+", "B", "B-", "C+", "C", "C-", "D+", "D", "D-", "F", "W"
New:
"A+", "A", "A-", "B+", "B", "B-", "C+", "C", "C-", "D+", "D", "D-", "F", "W", "P", "CR", "NC", "I", "NF"