Skip to content

Comments

Add files via upload#6

Open
DiegoGlezDiaz wants to merge 9 commits intoUTA-NURES:masterfrom
DiegoGlezDiaz:OPTIM
Open

Add files via upload#6
DiegoGlezDiaz wants to merge 9 commits intoUTA-NURES:masterfrom
DiegoGlezDiaz:OPTIM

Conversation

@DiegoGlezDiaz
Copy link

slightly modified version of the standard example script (without D)

slightly modified version of the standard example script (without D)
@DiegoGlezDiaz
Copy link
Author

Dear Bachar, et al,

It is Diego here. I am getting familiar with the process. I did a fork and modified the standard 'no-wrapper' script locally, appending _D (it is actually a new file). Just wanted to see how you react to this. Please let me know,

Copy link
Collaborator

@basharatoum basharatoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw your pull-request. This is the right way to do it, I can not accept it though, as those comments will be in our master branch. Also, we can not add the Test_PyBoltz_No_Wrapper_d.py file, because of the last two print statements.

You can try to add a different comment that could explain something, or add a simple punctuation to one of the comments.

Finally, it seems like the notifications are muted, I will go ahead and fix that. Thanks for the heads up with this pull-request.

New version of Pyboltz script
slightly modified version of PyBoltz script
header file for Pyboltz with 2 new variables on it (see previous commit)
->Mainly adding a variable WhichRandom to select between Magboltz random number with fixed seed (0), Python random number with fixed seed (1) and Python random number with random seed (2). This is done to cure a problem with the default option in master ('0' in the present version) that did not give deterministic results for T=/=0 (?).

->Also a variable to set the external downscaling in function Energylimit (formerly ISAMP) is added. This allows setting (in the initialization script) the difference between the number of collisions used in MONTE and a reduced value used for the estimate of the maximum energy. It is dubbed 'NcollSuppressionInElimits'.

->Also a control printout is added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants