Update gas file output to use alpha/eta SST values#14
Open
cuddandr wants to merge 4 commits intoUTA-NURES:masterfrom
Open
Update gas file output to use alpha/eta SST values#14cuddandr wants to merge 4 commits intoUTA-NURES:masterfrom
cuddandr wants to merge 4 commits intoUTA-NURES:masterfrom
Conversation
Updated OdieRun to use the alpha and eta SST calculation values in the gas file when the steady state threshold is crossed. Previously the gas file would always store the first calculation of alpha and eta. These values can be quite different from the later calculations of alpha and eta from the SST, PT, or TOF simulations. MagBoltz by default reports the SST calculations of alpha and eta if the steady state threshold has been crossed. OdieRun now does the same in the gas file. The Boltz class was modified to include a boolean flag to indicate if the steady state threshold has been crossed. NB: If the steady state threshold was crossed, but the SST simulation was not run, the flag is set to False as the alpha and eta SST values are not calculated.
The types of gases in a given mix are specified by strings in the settings dictionary. This commit adds alternative names/abbriviations for most gases for a more user friendly experience. Additionally the gas strings are now converted to upper case before comparison which makes them case-insensitive to the user. For example, PyBoltz now accepts N2, n2, or Nitrogen as a valid string for nitrogen gas instead of only NITROGEN. The ListGases() function now prints all accepted strings for each gas. Edited the printing of the settings dictionary to use the JSON pretty printing functionality.
Forgot to mention that the last commit only added the alternative gas names to the OdieRun interface. This commit ports the alternative gas names and modified functions to the PyBoltzRun interface.
benjpjones
approved these changes
Jan 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated OdieRun to use the alpha and eta SST calculation values in the
gas file when the steady state threshold is crossed.
Previously the gas file would always store the first calculation of
alpha and eta. These values can be quite different from the later
calculations of alpha and eta from the SST, PT, or TOF simulations.
MagBoltz by default reports the SST calculations of alpha and eta if the
steady state threshold has been crossed. OdieRun now does the same in
the gas file.
The Boltz class was modified to include a boolean flag to indicate if
the steady state threshold has been crossed.
NB: If the steady state threshold was crossed, but the SST simulation
was not run, the flag is set to False as the alpha and eta SST values
are not calculated.