Ensure that multiple different models can be used in the same R session. #50
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables multiple different MCSim models to be used simultaneously within the same R session by implementing model-specific naming for C functions and variables. Previously, all models shared common names (e.g., "initParms", "derivs"), causing conflicts when multiple models were loaded.
Key Changes:
- Modified compilation process to append model names to C function and variable names
- Updated model initialization to dynamically assign model-specific functions
- Fixed a spelling error in documentation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| DESCRIPTION | Updated version to 1.1.9000 for development |
| R/compileModel.R | Added logic to rename C and R objects with model-specific suffixes during compilation |
| R/MCSim_model.R | Modified model initialization to use dynamic assignment of model-specific functions |
| man/Model-class.Rd | Corrected spelling of "initial" in documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| r_command_string <- paste0("initStates <<- initStates_", mName) | ||
| r_expression <- parse(text = r_command_string) | ||
| eval(r_expression) |
There was a problem hiding this comment.
The pattern of building strings, parsing, and evaluating is repeated three times. Consider extracting this into a helper function to reduce duplication and improve maintainability. For example: assign_model_function <- function(name, mName) { eval(parse(text = paste0(name, ' <<- ', name, '_', mName))) }
| r_command_string <- paste0("Outputs <<- Outputs_", mName) | ||
| r_expression <- parse(text = r_command_string) | ||
| eval(r_expression) |
There was a problem hiding this comment.
The pattern of building strings, parsing, and evaluating is repeated three times. Consider extracting this into a helper function to reduce duplication and improve maintainability. For example: assign_model_function <- function(name, mName) { eval(parse(text = paste0(name, ' <<- ', name, '_', mName))) }
Updates that allow one to work with two different models simultaneously in the same R session. In previous versions of the package, attempting this could cause problems because a single set of C function and variable names (e.g., "initParms" and "Outputs") were used for all models that were created and loaded in a single R session. I've now updated the package so that all C function and object names are model-specific.