fix paging for rating spec getAll endpoint#1578
Merged
adamkorynta merged 6 commits intodevelopfrom Feb 12, 2026
Merged
Conversation
- the total size of rating specs was not queries, so next-page was never generated - optimize the query by paging and filtering just on the rating specs, not the rating specs + effective dates - optimize regex condition for "*" by setting it to noCondition(). This is especially helpful when columns are concatenations like TSIDs, Rating Ids, etc
Collaborator
|
Collaborator
Author
|
do you think I should capture both |
Collaborator
|
things that use * might work but imo they are broken and the default should be .* |
rma-rripken
reviewed
Feb 11, 2026
cwms-data-api/src/main/java/cwms/cda/data/dao/RatingSpecDao.java
Outdated
Show resolved
Hide resolved
Collaborator
|
Maybe an integration test that inserts a bunch and then pages the results and verifies they are all there? That is really what should have happened before you found this error. |
rma-rripken
reviewed
Feb 11, 2026
cwms-data-api/src/main/java/cwms/cda/data/dao/RatingSpecDao.java
Outdated
Show resolved
Hide resolved
rma-rripken
previously approved these changes
Feb 11, 2026
rma-rripken
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
caseInsensitiveLikeRegexcondition for"*"and".*"by setting it tonoCondition(). This is especially helpful when columns are concatenations like TSIDs, Rating Ids, etc