Fixing places where the office ID was not being converted to uppercase. #1571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Fixes #1562 |
Collaborator
|
I just ran into this same issues here: https://github.com/USACE/cwms-data-api/blob/develop/cwms-data-api/src/main/java/cwms/cda/data/dao/RatingSpecDao.java#L221 can you fix that line as well in this PR? |
zack-rma
approved these changes
Feb 10, 2026
Collaborator
|
Are those failing test cases the same ones that have been failing? Perhaps related: #1569 |
adamkorynta
previously approved these changes
Feb 11, 2026
… upperCasing. A GEOJSON test was counting on being able to pass null into the Locations retrieve.
Collaborator
Author
|
ok. Now I think its just the expected failures failing |
adamkorynta
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.