Skip to content

Add ack option to send command in SOTI CLI #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArnavG-it merged 1 commit into from
Dec 24, 2025
Merged

Add ack option to send command in SOTI CLI #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion soti/umsats_soti/parser/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ def parse_send(args: str, default_sender: NodeID) -> Message:
priority: int = 255
sender_id: NodeID = default_sender
recipient_id: NodeID | None = get_implied_recipient(cmd_id)
is_ack: bool = False

# represents the bytes that will be sent in the data section of the message
data = bytearray()
Expand All @@ -128,6 +129,13 @@ def parse_send(args: str, default_sender: NodeID) -> Message:
recipient_id = NodeID(parse_int(value))
except ValueError as exc:
raise ArgumentException(f"Invalid node ID '{value}'") from exc
elif key == "ack":
if value.lower() == "true":
is_ack = True
elif value.lower() == "false":
is_ack = False
else:
raise ArgumentException(f"Invalid value for ack '{value}'. Expected true or false")
else:
raise ArgumentException(f"Unknown option '{key}'")

Expand Down Expand Up @@ -183,5 +191,5 @@ def parse_send(args: str, default_sender: NodeID) -> Message:
priority,
sender_id,
recipient_id,
False
is_ack
)