Remove pugsql#48
Open
johnbarneson wants to merge 10 commits into
Open
Conversation
nihiliad
requested changes
Mar 24, 2022
| connection.commit() | ||
| except: | ||
| connection.rollback() | ||
| raise |
Member
There was a problem hiding this comment.
Since we're able to roll back this transaction, we can recover from this exception. We don't need to raise. As we do elsewhere in this project, let's log an error instead, something like this:
except Exception as e:
connection.rollback()
formatted_exception = loggers.format_exception(e)
experts_etl_logger.error(
f'exception encountered during updating pure_sync_data tables: {formatted_exception}'
)
Author
There was a problem hiding this comment.
I removed the raise and implemented exception error logging as noted above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is dependent on experts_dw having expsql.py. I don't think we can even think about merging until we test the Cx Oracle functionality.