Skip to content

Remove pugsql#48

Open
johnbarneson wants to merge 10 commits into
mainfrom
remove-pugsql
Open

Remove pugsql#48
johnbarneson wants to merge 10 commits into
mainfrom
remove-pugsql

Conversation

@johnbarneson
Copy link
Copy Markdown

This pull request is dependent on experts_dw having expsql.py. I don't think we can even think about merging until we test the Cx Oracle functionality.

Comment thread experts_etl/oit_to_edw/person.py Outdated
connection.commit()
except:
connection.rollback()
raise
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're able to roll back this transaction, we can recover from this exception. We don't need to raise. As we do elsewhere in this project, let's log an error instead, something like this:

        except Exception as e:
            connection.rollback()
            formatted_exception = loggers.format_exception(e)
            experts_etl_logger.error(
                f'exception encountered during updating pure_sync_data tables: {formatted_exception}'
            )

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the raise and implemented exception error logging as noted above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants