Merged
Conversation
The build was failing because the workflow was looking for dist/ in the root directory, but the build command creates it in umep-reqs/dist/. This commit: - Changes the build step to cd into umep-reqs directory before running setup.py - Updates both Test PyPI and PyPI publish steps to use umep-reqs/dist/ as the packages directory - Ensures the workflow can find the built distribution files in the correct location This should resolve the "No files found for package" error seen in the CI runs.
biglimp
approved these changes
Jul 3, 2025
- Only publish to Test PyPI when pushing to main branch (not on PRs) - Add verification step to check build artifacts are created correctly - List contents of dist/ directory after build for debugging This allows the workflow to run on PRs for testing the build process without attempting to publish (which would fail due to missing secrets).
- Adopt the new python -m build approach from main - Keep the PR testing improvements (only publish on main push) - Update paths to use root dist/ since pyproject.toml is now in root - Add verification step to check build artifacts The workflow now: 1. Uses modern Python build system with pyproject.toml 2. Only publishes to Test PyPI on main branch pushes 3. Runs build verification on all PRs without attempting to publish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
umep-reqs/subdirectoryProblem
The publish workflow was failing with "No files found for package" because:
setup.pyfile is located inumep-reqs/subdirectorypython umep-reqs/setup.py sdist bdist_wheelcreates dist files inumep-reqs/dist/dist/directorySolution
cd umep-reqs && python setup.py sdist bdist_wheelpackages_dir: umep-reqs/dist/This ensures the workflow can find the built distribution files in the correct location.
Test plan
umep-reqs/dist/