Skip to content

Conversation

@ALuesink
Copy link
Contributor

@ALuesink ALuesink commented Dec 15, 2025

  • Removed SST mix and positive controls from the plots in the Excel files.
  • Moved code to functions
  • Added unit tests for new functions

@ALuesink ALuesink changed the title Feature/dims excel plots Feature/DIMS_Excel_plots Dec 15, 2025
@ALuesink ALuesink marked this pull request as ready for review December 19, 2025 08:08
@rernst rernst self-requested a review January 13, 2026 08:31
Copy link
Member

@rernst rernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ziet er goed uit, ik denk dat je naamgeving soms wat duidelijker/simpeler kan maken. Verder zit er nog een stukje code duplicatie in wat je volgens mij bij de create_boxplot_excel functie kan toevoegen.

@rernst rernst self-requested a review January 27, 2026 13:23
Copy link
Member

@rernst rernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mooi verbeteringen :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants