Conversation
ggamnunq
reviewed
Nov 30, 2025
| .orElseThrow(() -> new MemberException(MemberErrorCode.NOT_FOUND)); | ||
|
|
||
| int pageIndex = page - 1; | ||
| int size = 10; // 한 페이지당 10개 |
| .map(ReviewConverter::toMyReview) | ||
| .toList()) | ||
| .listSize(result.getSize()) | ||
| .totalPage(result.getTotalPages()) |
There was a problem hiding this comment.
개인적으로 페이징 정보는 공통 클래스를 만들어서 그걸 반환하는걸 선호합니다.
응답 DTO마다 필드를 만들면 api마다 페이징 정보에 대한 필드명이 달라질 수도 있습니다.
그러면 프론트 팀원이 매우 싫어해요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
#11