Conversation
…nsfer still missing
Shared memory functionality is expanded and now supports input and output for: Evaluate, Gradient, Jacobian and Hessian. Umbridge automatically attempts a shared memory transmission in order to detect accessibility and falls back to full HTTP/JSON transmission on failure. Currently, the shared memory segments will only be compiled on Linux, may be expanded to Apple Mac (needs testing).
Shared memory functionality is expanded and now supports input and output for: Evaluate, Gradient, Jacobian and Hessian. Umbridge automatically attempts a shared memory transmission in order to detect accessibility and falls back to full HTTP/JSON transmission on failure. Works on Linux and Windows. MacOS is to be tested.
Fix indentation for comparison
Member
|
Looks good, thanks a lot! Can you remove the draft status? Apparently there's also a potential merge conflict, could you look into that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added shared memory functionality for input and output of Evaluate, Gradient, Jacobian and Hessian functions. Automatic fallback to http/json if test transmission fails.
Discussing possible improvements.