fix(data): Handle missing papers.jsonl file#6
Open
VooDisss wants to merge 1 commit intoUKPLab:mainfrom
Open
Conversation
This commit fixes a bug where the data processing pipeline would crash if the `data/papers.jsonl` file was missing or empty. The `PaperLoader` class in `peerqa/data_loader.py` would unconditionally try to read `papers.jsonl` at initialization, causing a `ValueError` if the file didn't exist. This would prevent the `extract_text_from_pdf.py` script from running and creating the file in the first place. This commit makes the `PaperLoader` more robust by: - Checking if `papers.jsonl` exists and is not empty before reading it. - Initializing an empty DataFrame if the file is missing, allowing the script to proceed. - Adding a safeguard to `has_paper_id` to handle an empty DataFrame. This ensures that the data processing pipeline can be run from a clean state without errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where the data processing pipeline would crash if the
data/papers.jsonlfile was missing or empty.The
PaperLoaderclass inpeerqa/data_loader.pywould unconditionally try to readpapers.jsonlat initialization, causing aValueErrorif the file didn't exist. This would prevent theextract_text_from_pdf.pyscript from running and creating the file in the first place.This commit makes the
PaperLoadermore robust by:papers.jsonlexists and is not empty before reading it.has_paper_idto handle an empty DataFrame.This ensures that the data processing pipeline can be run from a clean state without errors.