Fix ESLint configuration and resolve all unused variable errors#132
Merged
dennis-zyska merged 2 commits intodevfrom Apr 1, 2026
Merged
Fix ESLint configuration and resolve all unused variable errors#132dennis-zyska merged 2 commits intodevfrom
dennis-zyska merged 2 commits intodevfrom
Conversation
- Changed error variable names in multiple components to use underscore prefix for clarity. - Updated ESLint configuration to include a new rule for unused variables, enhancing code quality. - Removed unnecessary variable declarations in various components to streamline code.
dennis-zyska
requested changes
Mar 25, 2026
| variant: "success" | ||
| }); | ||
| } catch ($e) { | ||
| } catch (_$e) { |
Collaborator
There was a problem hiding this comment.
if we align it, should we do _error instead of _$e ?
Collaborator
Author
There was a problem hiding this comment.
"_" should be fine
| variant: "success" | ||
| }); | ||
| } catch ($e) { | ||
| } catch { |
Collaborator
There was a problem hiding this comment.
here you removed it completely, please align with the other cases
- Updated error variable names across multiple components to use `_error` for consistency. - Modified ESLint configuration to enforce naming conventions for caught errors. - Improved error handling in various components to enhance code clarity and maintainability.
dennis-zyska
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed all unused variables, imports, and parameters from the frontend.
New User Features
New Dev Features
_Improvements
Bug Fixes
make lintcrash due to outdated config formatKnown Limitations
Future Steps