task/CDD-3293-CMS-FIX-Dual-category-chart-component#3208
Open
jeanpierrefouche-ukhsa wants to merge 5 commits into
Open
task/CDD-3293-CMS-FIX-Dual-category-chart-component#3208jeanpierrefouche-ukhsa wants to merge 5 commits into
jeanpierrefouche-ukhsa wants to merge 5 commits into
Conversation
jeanpierrefouche-ukhsa
force-pushed
the
task/CDD-3293-CMS-FIX-Dual-category-chart-component
branch
2 times, most recently
from
a920515 to
13797d4
Compare
jeanpierrefouche-ukhsa
force-pushed
the
task/CDD-3293-CMS-FIX-Dual-category-chart-component
branch
from
13797d4 to
c6c452c
Compare
jeanpierrefouche-ukhsa
force-pushed
the
task/CDD-3293-CMS-FIX-Dual-category-chart-component
branch
from
c6c452c to
a81508c
Compare
jeanpierrefouche-ukhsa
force-pushed
the
task/CDD-3293-CMS-FIX-Dual-category-chart-component
branch
from
a81508c to
0814e39
Compare
fix secondary categories not updating the issue is with the selector for the segments form - this was not finding the form task/CDD-3293-CMS-FIX-Dual-category-chart-component delete all segments on change task/CDD-3293-CMS-FIX-Dual-category-chart-component Fix observer - added appropriate class attribute, fixed the matcher to use appropriate css call instead of string.contains
fix multiple charts issue: - DualCategoryChartCardBlockDefinition is a singleton and so the code needs to treat each chart as a new instance. - CSS queries must be scoped to rootNode, this being the DOM root element on which each chart is rendered.
jeanpierrefouche-ukhsa
force-pushed
the
task/CDD-3293-CMS-FIX-Dual-category-chart-component
branch
from
0814e39 to
d4f90a8
Compare
Changelog document
phill-stanley
approved these changes
May 28, 2026
Find rootNode dynamically instead of hard-coding to 4th element
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the following:
Fixes #CDD-<ISSUE_ID>
Type of change
Please select the options that are relevant.
Checklist: