Update Hermes-3#36
Open
mikekryjak wants to merge 16 commits into
Open
Conversation
This only checks the formatting, and relies on prek for users to do the formatting. Co-authored-by: Peter Hill <peter.hill@york.ac.uk>
Co-authored-by: Peter Hill <peter.hill@york.ac.uk>
Co-authored-by: Peter Hill <peter.hill@york.ac.uk>
Co-authored-by: Peter Hill <zed.three@gmail.com>
Copy CI formatting from BOUT++
Fix by merging in changes from 1D-threshold. The neutral_parallel_diffusion diffusion mode is changed to "multispecies" from the default "afn" so that neutral-neutral collisions are included.
Just in case there are no collisions, limit the collision frequency to a small non-zero value.
If species1 was charged and species2 was neutral then the `ion_neutral` option was not used: These collisions were always included. The `ion_neutral` option was used in neutral/charged collisions. This was caught by the new GuardedOptions system. Thanks Chris!
Updated so they run when restarted from 1D-hydrogen
Would have caught the issue with ion_neutral switch.
Fixes for 1D examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Hermes-3. This is to get access to the new formatting workflow:
https://bout-dev.readthedocs.io/en/latest/developer_docs/contributing.html#formatting-and-linters
I have also added
uvto the Spack python env to allow the formatters to be installed into the formatter environment.