Skip to content

make @types/openui5 a dev dependency#13460

Open
nkappler wants to merge 1 commit intoUI5:mainfrom
nkappler:patch-1
Open

make @types/openui5 a dev dependency#13460
nkappler wants to merge 1 commit intoUI5:mainfrom
nkappler:patch-1

Conversation

@nkappler
Copy link
Copy Markdown

@nkappler nkappler commented May 4, 2026

when installing the webcomponents, they pull in @types/openui5 as a dependency, although it should be a dev dependency.
This leads to conflicts in our repository, since we use patch-package to patch incorrect types in that package, but additional copy added by webcomponents is overwriting them again...

fix #13459

@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented May 4, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nkappler nkappler changed the title fix (ui5-13459) make @types/openui5 a dev dependency make @types/openui5 a dev dependency May 4, 2026
@nnaydenow
Copy link
Copy Markdown
Contributor

Hi @pskelin,

could you check here?

@nkappler
Copy link
Copy Markdown
Author

nkappler commented May 5, 2026

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I was trying to sign the CLA but the link seems to be broken

@pskelin
Copy link
Copy Markdown
Contributor

pskelin commented May 5, 2026

@nkappler this was specifically added as a dependency with #6346
before that, there was an error that the types are not portable - they appear in the .d.ts files that we ship (we extend them in some places in the localization package), and if the types are not a dependency, consumers will get errors or have to install the types themselves.

can you check why patch package fails? it should not be an issue if multiple packages in your repo point have the same dependency, patch package usually runs after npm install so it should still apply the patch regardless of the way the dependency came.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openui5 types should be a dev dependency

3 participants