You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
when installing the webcomponents, they pull in @types/openui5 as a dependency, although it should be a dev dependency.
This leads to conflicts in our repository, since we use patch-package to patch incorrect types in that package, but additional copy added by webcomponents is overwriting them again...
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You have signed the CLA already but the status is still pending? Let us recheck it.
nkappler
changed the title
fix (ui5-13459) make @types/openui5 a dev dependency
make @types/openui5 a dev dependency
May 4, 2026
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.
I was trying to sign the CLA but the link seems to be broken
@nkappler this was specifically added as a dependency with #6346
before that, there was an error that the types are not portable - they appear in the .d.ts files that we ship (we extend them in some places in the localization package), and if the types are not a dependency, consumers will get errors or have to install the types themselves.
can you check why patch package fails? it should not be an issue if multiple packages in your repo point have the same dependency, patch package usually runs after npm install so it should still apply the patch regardless of the way the dependency came.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when installing the webcomponents, they pull in @types/openui5 as a dependency, although it should be a dev dependency.
This leads to conflicts in our repository, since we use patch-package to patch incorrect types in that package, but additional copy added by webcomponents is overwriting them again...
fix #13459