Skip to content

fix(ui5-combobox): show focus outline on list item mousedown #13449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivoplashkov wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −0
Open

fix(ui5-combobox): show focus outline on list item mousedown #13449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions packages/main/cypress/specs/ComboBox.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,21 @@ describe("General Interaction", () => {
cy.get("[ui5-combobox]").should("have.prop", "focused", true);
});

it("shows focus outline on list item mousedown", () => {
cy.mount(
<ComboBox>
<ComboBoxItem text="One" />
<ComboBoxItem text="Two" />
</ComboBox>
);

cy.get("[ui5-combobox]").shadow().find(".inputIcon").realClick();
cy.get("[ui5-combobox]").shadow().find("[ui5-responsive-popover]").should("have.attr", "open");

cy.get("[ui5-cb-item]").first().shadow().find("li").realMouseDown();
cy.get("[ui5-cb-item]").first().should("have.prop", "focused", true);
});

it("tests Combo with two-column layout", () => {
cy.mount(
<ComboBox>
Expand Down
8 changes: 8 additions & 0 deletions packages/main/src/ComboBox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1383,6 +1383,14 @@ class ComboBox extends UI5Element implements IFormInputElement {

_itemMousedown(e: MouseEvent) {
e.preventDefault();

const target = e.target as HTMLElement;
const listItem = target.closest<ComboBoxItem>("[ui5-cb-item], [ui5-cb-item-group]");

if (listItem) {
this._clearFocus();
listItem.focused = true;
}
}

_selectItem(e: CustomEvent<ListItemClickEventDetail>) {
Expand Down
Loading