feat(ui5-list): add live region announcement for item selection#13440
Open
NakataCode wants to merge 3 commits intomainfrom
Open
feat(ui5-list): add live region announcement for item selection#13440NakataCode wants to merge 3 commits intomainfrom
NakataCode wants to merge 3 commits intomainfrom
Conversation
Announces "Selected" or "Not Selected" via InvisibleMessage when a list item's selection state changes in any selectionMode other than "None". Covers Single, SingleStart, SingleEnd, SingleAuto, and Multiple modes.
Collaborator
|
🚀 Deployed on https://pr-13440--ui5-webcomponents-preview.netlify.app |
Contributor
Author
Code reviewFound 2 issues:
webcomponents/packages/main/src/List.ts Lines 39 to 42 in d8200f0 The fix:
webcomponents/packages/main/src/List.ts Lines 921 to 932 in d8200f0 The fix: guard the 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
What's covered: