fix(ui5-dynamic-page): correct scroll-padding-top for focus auto-scroll#13418
Open
plamenivanov91 wants to merge 3 commits intomainfrom
Open
fix(ui5-dynamic-page): correct scroll-padding-top for focus auto-scroll#13418plamenivanov91 wants to merge 3 commits intomainfrom
plamenivanov91 wants to merge 3 commits intomainfrom
Conversation
Keep pointer interactions stable by skipping focus-driven auto-scroll after pointer down in the content area. For keyboard navigation, scroll only when the focused element is actually clipped by the effective visible content viewport. Keep smooth scrolling when auto-scroll is needed. Add and update DynamicPage Cypress coverage for: - no scroll shift on content button click with partially hidden header - no scroll shift on tab focus when target is already visible Fixes: #13332
Collaborator
|
🚀 Deployed on https://pr-13418--ui5-webcomponents-preview.netlify.app |
kineticjs
reviewed
Apr 23, 2026
kineticjs
requested changes
Apr 23, 2026
plamenivanov91
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the pointer-down focus-skip workaround with a scroll-padding-top calculation based on the actually overlapped sticky area (title/header and current scrollTop), so visible content no longer shifts on click while partially clipped controls can still scroll into view on keyboard focus.
Keep smooth scroll behavior when auto-scroll is needed.
Add/update DynamicPage Cypress coverage for:
no scroll shift on content button click with partially hidden header
no scroll shift on tab focus when target is already visible
partially clipped textarea is scrolled into view on Tab focus
Fixes: #13332