fix(OpenUI5Support): override default [popover] padding#13019
fix(OpenUI5Support): override default [popover] padding#13019s-todorova wants to merge 1 commit intomainfrom
Conversation
SNOW: DINC0776938
|
🚀 Deployed on https://pr-13019--ui5-webcomponents-preview.netlify.app |
| border: none; | ||
| overflow: visible; | ||
| margin: 0; | ||
| padding: 0; |
There was a problem hiding this comment.
This will clear the left/right paddings (reported in the related issue), but there is a chance to also overwrite/reset the sap.m.Dialog's top and bottom paddings. Did you verify this? If yes - then it's good to go.
There was a problem hiding this comment.
Tested on local page for OpenUi5Support - seemed ok.
There was a problem hiding this comment.
I imagine verifying it on the reproducible environment (because the release + consumption cycle is a long process) but this is up to you - I am fine with the change itself.
| border: none; | ||
| overflow: visible; | ||
| margin: 0; | ||
| padding: 0; |
There was a problem hiding this comment.
Yes, this will override the bottom and top paddings of the sap.m.Dialog.
The issue is visible if you add footer to some dialog in the DialogAndOpenUI5Dialog.html like:
new Dialog("openUI5DialogWithButtons", {
buttons: [
new Button({
text: "Close",
press: function () {
this.getParent().close();
}
})
],
This will also override the default paddings of the .sapMValueStateMessage and .sapMMessageToast classes. Probably and some others.
I think it will be better to fix the issue in the OpenUI5 project.
Add to
- .sapMDialog - padding-inline: 0;
- .sapMPopover - padding: 0;
- .sapMLightBox - padding: 0;
- .sapUiHintContainer - padding: 0;
4 participants
SNOW: DINC0776938