feat(ui5-color-palette*): resolve landmark uniqueness and missing dialog label#12967
Open
feat(ui5-color-palette*): resolve landmark uniqueness and missing dialog label#12967
Conversation
Collaborator
|
🚀 Deployed on https://pr-12967--ui5-webcomponents-preview.netlify.app |
unazko
approved these changes
Jan 29, 2026
nnaydenow
reviewed
Feb 2, 2026
Contributor
|
I've tested the |
tsanislavgatev
requested changes
Feb 3, 2026
tsanislavgatev
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Currently in our
ui5-color-paletteall color palette items share the same "Color Palette" label for elements withrole="region". The problem is that landmarks should have a unique role or role/label/title combination.The
role="region"creates a landmark - Landmarks are navigational waypoints that must have unique labels across the entire pageWhen multiple
ui5-color-palettecomponents exist on the same page, they ALL hadrole="region"with the same label "Color Palette". This caused a WCAG 2.2 AA violation: Multiple landmarks with identical labels confuse screen reader users.Solutions
So, that's why we will now use
role="group".We also added
accessibleName