Skip to content

refactor(ui5-table): use generics for table cell types #12771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aborjinik merged 1 commit into from
Dec 9, 2025
Merged

refactor(ui5-table): use generics for table cell types #12771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/main/src/Table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ class Table extends UI5Element {
}

const widths = [];
const visibleHeaderCells = this.headerRow[0]._visibleCells as TableHeaderCell[];
const visibleHeaderCells = this.headerRow[0]._visibleCells;

// Selection Cell Width
if (this._isRowSelectorRequired) {
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/TableCustomAnnouncement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ class TableCustomAnnouncement extends TableExtension {
descriptions.push(i18nBundle.getText(TABLE_ROW_ACTIVE));
}

const cells = [...row._visibleCells, ...row._popinCells] as TableCell[];
const cells = [...row._visibleCells, ...row._popinCells];
cells.flatMap(cell => {
return cell._popin ? [cell._popinHeader!, cell._popinContent!] : [cell._headerCell, cell];
}).forEach(node => {
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/TableHeaderRow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ import {
*
* @public
*/
class TableHeaderRow extends TableRowBase {
class TableHeaderRow extends TableRowBase<TableHeaderCell> {
/**
* Defines the cells of the component.
*
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/TableRow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import {
styles: [TableRowBase.styles, TableRowCss],
template: TableRowTemplate,
})
class TableRow extends TableRowBase {
class TableRow extends TableRowBase<TableCell> {
/**
* Defines the cells of the component.
*
Expand Down
4 changes: 2 additions & 2 deletions packages/main/src/TableRowBase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ import {
renderer: jsxRenderer,
styles: TableRowBaseCss,
})
abstract class TableRowBase extends UI5Element {
cells!: Array<TableCellBase>;
abstract class TableRowBase<TCell extends TableCellBase = TableCellBase> extends UI5Element {
cells!: Array<TCell>;

@property({ type: Number, noAttribute: true })
_invalidate = 0;
Expand Down
1 change: 1 addition & 0 deletions packages/main/src/themes/TableGrowing.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
flex-direction: column;
cursor: pointer;
border-bottom: 1px solid var(--sapList_BorderColor);
background: var(--sapList_Background);
}

#button:focus {
Expand Down
Loading