Skip to content

wip(ui5-product-switch-item): add icon part #12764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nnaydenow wants to merge 1 commit into from
Closed

wip(ui5-product-switch-item): add icon part #12764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions packages/fiori/src/ProductSwitchItemTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default function ProductSwitchItemTemplate(this: ProductSwitchItem) {
href={this.targetSrc}
target={this._effectiveTarget}
>
{ item.call(this) }
{item.call(this)}
</a>
:
<div
Expand All @@ -31,7 +31,7 @@ export default function ProductSwitchItemTemplate(this: ProductSwitchItem) {
onKeyUp={this._onkeyup}
tabindex={this.forcedTabIndex ? parseInt(this.forcedTabIndex) : undefined}
>
{ item.call(this) }
{item.call(this)}
</div>
}
</>
Expand All @@ -41,17 +41,18 @@ export default function ProductSwitchItemTemplate(this: ProductSwitchItem) {
function item(this: ProductSwitchItem) {
return (
<>
{this.image && this.image.length > 0 ? (
<span class="ui5-product-switch-item-image-placeholder">
<span class="ui5-product-switch-item-image-placeholder">
{this.image && this.image.length > 0 ? (
<slot name="image"></slot>
</span>
) : (
this.icon &&
<Icon
class="ui5-product-switch-item-icon"
name={this.icon}
/>
)}
) : (
this.icon &&
<Icon
part="icon"
class="ui5-product-switch-item-icon"
name={this.icon}
/>
)}
</span>

<span class="ui5-product-switch-item-text-content">
{this.titleText &&
Expand Down
14 changes: 8 additions & 6 deletions packages/fiori/src/themes/ProductSwitchItem.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,8 @@
}

.ui5-product-switch-item-root .ui5-product-switch-item-icon {
width: 3rem;
height: 3rem;
padding: .75rem;
margin-bottom: .5rem;
width: 1.5rem;
height: 1.5rem;
box-sizing: border-box;
color: var(--sapContent_IconColor);
pointer-events: none;
Expand All @@ -76,6 +74,10 @@
width: 3rem;
height: 3rem;
margin-bottom: .5rem;
display: flex;
justify-content: center;
align-items: center;
box-sizing: border-box;
}

.ui5-product-switch-item-root .ui5-product-switch-item-text-content {
Expand Down Expand Up @@ -133,9 +135,9 @@
}

.ui5-product-switch-item-root .ui5-product-switch-item-icon {
padding: .875rem;
width: 1.25rem;
height: 1.25rem;
color: var(--sapContent_NonInteractiveIconColor);
margin: 0 .75rem 0 0;
}

.ui5-product-switch-item-root .ui5-product-switch-item-image-placeholder {
Expand Down
11 changes: 9 additions & 2 deletions packages/fiori/test/pages/ProductSwitch.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@


<script src="%VITE_BUNDLE_PATH%" type="module"></script>
<style>
.custom-icon::part(icon) {
width: 2.5rem;
height: 2.5rem;
color: red;
}
</style>


<script>
Expand All @@ -32,15 +39,15 @@
</ui5-product-switch-item>
<ui5-product-switch-item title-text="Analytics Cloud" subtitle-text="Analytics Cloud" icon="business-objects-experience"></ui5-product-switch-item>
<ui5-product-switch-item title-text="Catalog" subtitle-text="Ariba" icon="contacts"></ui5-product-switch-item>
<ui5-product-switch-item title-text="Guided Buying" icon="credit-card"></ui5-product-switch-item>
<ui5-product-switch-item class="custom-icon" title-text="Guided Buying" icon="credit-card"></ui5-product-switch-item>
</ui5-product-switch>

<ui5-product-switch id="productSwitchFourColumn">
<ui5-product-switch-item id="firstItem" title-text="Home" subtitle-text="Central Home" icon="home"></ui5-product-switch-item>
<ui5-product-switch-item title-text="Analytics Cloud" subtitle-text="Analytics Cloud" icon="business-objects-experience"></ui5-product-switch-item>
<ui5-product-switch-item title-text="Catalog" subtitle-text="Ariba" icon="contacts"></ui5-product-switch-item>
<ui5-product-switch-item title-text="Guided Buying" icon="credit-card"></ui5-product-switch-item>
<ui5-product-switch-item title-text="Strategic Procurement" icon="cart-3"></ui5-product-switch-item>
<ui5-product-switch-item class="custom-icon" title-text="Strategic Procurement" icon="cart-3"></ui5-product-switch-item>
<ui5-product-switch-item title-text="Travel & Expense" subtitle-text="Concur" icon="flight"></ui5-product-switch-item>
<ui5-product-switch-item title-text="Vendor Management" subtitle-text="Fieldglass" icon="shipping-status"></ui5-product-switch-item>
<ui5-product-switch-item title-text="Human Capital Management" icon="customer"></ui5-product-switch-item>
Expand Down
Loading